Skip to content

Implement Follow Up Question And Answer Flow#376

Merged
sagrimson merged 4 commits into
datacommonsorg:mainfrom
madebypxlp:paulo/follow-up
Jun 24, 2026
Merged

Implement Follow Up Question And Answer Flow#376
sagrimson merged 4 commits into
datacommonsorg:mainfrom
madebypxlp:paulo/follow-up

Conversation

@PauloMFJ

@PauloMFJ PauloMFJ commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Overview

This PR implements follow up question and answer flow. Note: How this is connected is still up in the air so for now just hooked up a very basic flow. It's very temporary but will be reworked later so wouldn't pay too much attention to that part for now.

Screenshot

image

Testing

  • To demonstrate the (mocked up) follow-up flow, click on the fourth sample choice option "What fraction of the world is forest".

@PauloMFJ PauloMFJ self-assigned this Jun 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new FollowUp component to display questions, answers, and follow-up prompts, integrates it into the home page with mock data for demonstration, and updates color tokens in colors.json. The review feedback highlights opportunities to improve HTML semantics and accessibility in the FollowUp component by replacing the h2 heading with a paragraph tag and using a div instead of a p tag for multi-paragraph answers. Additionally, it is recommended to make the conditional rendering of panels in PageHome mutually exclusive to prevent concurrent rendering issues during transitions.

Comment thread dataweaver/apps/web/src/components/scopes/page_home/page_home.tsx Outdated
Comment thread dataweaver/apps/web/src/components/scopes/page_home/follow_up.tsx Outdated
Comment thread dataweaver/apps/web/src/components/scopes/page_home/follow_up.tsx Outdated
PauloMFJ and others added 2 commits June 23, 2026 11:01
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

@nick-nlb nick-nlb left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Paulo!

I don't think we've had significant discussion yet on the flow of back-and-forth interaction between DW and the user before DW breaks into showing data. Let's add that to the agenda for Friday.

@sagrimson sagrimson merged commit 671356d into datacommonsorg:main Jun 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants